core: Clean up ExternalInterface a little #18223
Open
+87
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we never use more than 1
…stead of get-then-call
Dinnerbone
added
A-core
evilpie
reviewed
Oct 10, 2024
| for arg in &args[1..] { | ||
| external_args.push(ExternalValue::from_avm1(activation, arg.to_owned())?); | ||
| } | ||
| let mut external_args = Vec::with_capacity(external_args_len); |
There was a problem hiding this comment.
I would probably write this using an iterator an map.
evilpie
reviewed
Oct 10, 2024
| } else { | ||
| Ok(Value::Null) | ||
| let mut external_args = Vec::with_capacity(args.len() - 1); | ||
| for arg in &args[1..] { |
evilpie
reviewed
Oct 10, 2024
| } | ||
|
|
||
| pub fn available(&self) -> bool { | ||
| !self.providers.is_empty() | ||
| self.provider.is_some() | ||
| } | ||
|
|
||
| pub fn any_id(&self) -> Option<String> { |
There was a problem hiding this comment.
I think we could rename this to get_id now.
evilpie
reviewed
Oct 10, 2024
| fn is_location_href(code: &str) -> bool { | ||
| matches!( | ||
| code, | ||
| "document.location.href" | "window.location.href" | "top.location.href" | ||
| ) | ||
| } | ||
|
|
||
| struct FakeEval(Option<Url>); | ||
|
|
||
| impl ExternalInterfaceMethod for FakeEval { |
evilpie
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of getting a method then calling it, we just call things directly now. We also can now only have one Provider instead of many, but realistically there's no case in which multiple providers can peacefully coexist as they'll be conflicting with methods.